Add sglang repo in to find_kernel_sources sources#37
Open
haofrank wants to merge 3 commits into
Open
Conversation
| "sgl_hip", | ||
| "write_req_to_token_pool", | ||
| "create_flashinfer_kv_indices", | ||
| "flashinfer", |
Collaborator
There was a problem hiding this comment.
hmm do you think there is a chance that this might misroute FlashInfer kernels into SGLang/$SGLANG_DIR
| INDUCTOR_PATTERN = re.compile(r'triton_\w+_fused_') | ||
| HIPBLASLT_PATTERN = re.compile(r'wvSplitK|wvSpltK|DeviceGemmWmma') | ||
| AITER_PATTERN = re.compile(r'^_ZN5aiter|aiter::') | ||
| SGLANG_PATTERN = re.compile( |
Collaborator
There was a problem hiding this comment.
is there any correlation with _is_sglang_kernel in searcher.py? there is some regex difference with that.
| ) | ||
| ) | ||
|
|
||
| def _search_sglang_source(self, function_name: str, original_name: str) -> Optional[SourceMatch]: |
Collaborator
There was a problem hiding this comment.
shall we make this consistent with rest? Every other search*_source returns None when nothing is found
| from Magpie.tools.amd_kernel_finder import KernelSourceInfo | ||
| headers.extend(KernelSourceInfo.csv_headers()) | ||
| f.write( | ||
| "# Warning: columns 7-19 from find_kernel_sources/testcase " |
Collaborator
There was a problem hiding this comment.
are we going to have these columns always the same? so always 7-19?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental
find_kernel_sourcesfeature has been added to the AMD benchmark gap analysis within the SGLang repository. It is now possible to search for relevant kernel source code and test cases directly within SGLang.