Open
Conversation
Dodolist
requested changes
Sep 24, 2024
Collaborator
Dodolist
left a comment
There was a problem hiding this comment.
전체적으로 확인해보니 아직 정리가 필요한 부분이 보여요!
util 내부에 util.js안에 코드가 남아있는 부분도 있고
style도 분리하면서 원래 코드에도 제거를 해야하는데 코드가 남아있어보여요.
변경 해주시면 다시 리뷰 진행할게요!
src/components/TopBar/components/ChangePasswordModalChildren.js
Outdated
Show resolved
Hide resolved
src/components/TopBar/components/ChangePasswordModalChildren.js
Outdated
Show resolved
Hide resolved
Member
Author
|
PR 리류 남겨주신 사항 모두 반영했습니다! |
Member
Author
|
병합 충돌도 변경해놨어요-! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
TopBar 컴포넌트가 복잡해져 리팩토링을 진행했습니다.
작업 사항
예정 사항
논의 사항
리팩토링 서로 얘기하면서 진행하면 좋을 것 같아서 많은 comment 부탁드립니당🙋🏻♂️