perf: Changed parameter type Number to const Number&
#69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed parameter type `Number` to `const Number&` where applicable. This improves performance for custom types like arbitrary-precision or symbolic numbers, but slightly reduces performance for fundamental types like `float` or `double`. - Reduced the precision of tests for quadratic and cubic splines on "Fast" and "FastParallel" profiles, as the precision was unexpectedly affected by optimizations from the `-Ofast` option, specifically `-ffast-math`. The behavior remains unchanged on other profiles.
pasabanov
added
perf
pasabanov
changed the title
Number to const Number&Number to const Number&
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Changed parameter type
Numbertoconst Number&where applicable.This improves performance for custom data types like arbitrary-precision or symbolic numbers, but may slightly reduce performance when using
floatordoubleasNumber.Reduced the precision of tests for quadratic and cubic splines on "Fast" and "FastParallel" profiles, as the precision was unexpectedly affected by optimizations from the
-Ofastoption, specifically-ffast-math.The behavior remains unchanged on other profiles.