Skip to content

Refined epsilon handling: consider boundary values as equal #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasabanov merged 1 commit into from
Apr 1, 2025
Merged

Refined epsilon handling: consider boundary values as equal #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ALFI/ALFI/util/linalg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ namespace alfi::util::linalg {
i_max = k;
}
}
if (max_a < epsilon) {
if (max_a <= epsilon) {
std::cerr << "Error in function " << __FUNCTION__ << ": Matrix A is degenerate. Returning an empty array..." << std::endl;
return {};
}
Expand Down
2 changes: 1 addition & 1 deletion ALFI/ALFI/util/numeric.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
namespace alfi::util::numeric {
template <typename Number = DefaultNumber>
bool are_equal(Number a, Number b, Number epsilon = std::numeric_limits<Number>::epsilon()) {
return std::abs(a - b) < epsilon || std::abs(a - b) < std::max(std::abs(a), std::abs(b)) * epsilon;
return std::abs(a - b) <= epsilon || std::abs(a - b) <= std::max(std::abs(a), std::abs(b)) * epsilon;
}
}
2 changes: 1 addition & 1 deletion tests/test_data
Open in desktop
Submodule test_data updated 4 files
+3 −1 .gitignore
+42 −0 .vscode/settings.json
+1 −1 misc/generate.py
+2 −2 spline/generate_step.py