chore(dx): add package.json#type for npm package releases #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
## 概述
The changes ensure Node.js correctly interprets module formats by adding `package.json` files with appropriate `type` settings to distribution folders.
## 变更
| Files | Summary |
|-----------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------|
| `packages/agent-library/scripts/after-build.js`, `packages/core/scripts/after-build.js` | Added `package.json` files to distribution folders, setting `type` to "commonjs" for CJS and "module" for ESM directories. | |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (2)
- packages/agent-library/scripts/after-build.js (1)
- packages/core/scripts/after-build.js (1)
Files ignored due to filter (2)
- packages/agent-library/package.json
- packages/core/package.json
Review comments generated (3)
- Review: 3
- LGTM: 0
提示
与 
CodeRabbit 机器人 (@coderabbitai) 聊天
- 回复此机器人留下的审查评论以提出后续问题。审查评论是对差异或文件的评论。
- 通过在回复中标记
@coderabbitai邀请机器人加入审查评论链。
代码建议
- 机器人可能会提出代码建议，但在提交前请仔细审查它们，因为行号范围可能会不对齐。
- 你可以编辑机器人做出的评论，并在建议稍有偏差时手动调整。
暂停增量审查
- 在 PR 描述中的任何位置添加
@coderabbitai: ignore以暂停机器人的进一步审查。
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
wangshijun
changed the title
wangshijun
reviewed
Mar 26, 2025
wangshijun
previously approved these changes
Mar 26, 2025
wangshijun
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Major Changes
Checklist
None
Summary by CodeRabbit
package.jsonfiles to distribution folders for both CJS and ESM formats. This ensures Node.js correctly interprets the module format, enhancing compatibility and module resolution.