Repository navigation
Enforce signed commits: pre-push hook, check scripts, and CI workflow - #4
Merged
Merged
Conversation
Copied verbatim from FlightDirector for consistency across repos: .githooks/pre-push, scripts/runChecks.sh, scripts/checks/lint.sh, scripts/checks/verifyGitLogs.sh (accepts %G? of G or U), and .yamllint.yaml. Adds .github/workflows/verify-signed-commits.yml, which fails a pull request if GitHub reports any of its commits as unverified, and a CONTRIBUTING.md describing the hook setup and the signing rule. Closes #3 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.githooks/pre-push,scripts/runChecks.sh,scripts/checks/verifyGitLogs.sh(accepts%G?ofGorU),scripts/checks/lint.sh,.yamllint.yaml..github/workflows/ci-global-commits-signed.yaml: fails a pull request if GitHub reports any of its commits as unverified.CONTRIBUTING.mdwith the hook setup (git config core.hooksPath .githooks) and the signing rule.Test plans
#3 — Enforce signed commits
ci-global-commits-signedworkflow ran on this PR and itsall commits verifiedjob passed, listing both commits as verified.git config core.hooksPath .githooks, thenscripts/runChecks.sh.git -c commit.gpgsign=false commit --allow-empty -m tmpand runscripts/checks/verifyGitLogs.sh 1; discard the commit afterwards.main, require theall commits verifiedstatus check.Expected: step 1 is green; step 2 reports all checks passed; step 3 fails with the commit shown as
[N]; after step 4 a PR with an unverified commit cannot be merged.Closes #3
🤖 Generated with Claude Code