-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of the rules depending on users #585
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
"allow": "all" | ||
}, | ||
{ | ||
"user": "ccx-admin|ccx-reporting-pipeline-trino", | ||
"group": "ccx-datalake-owners", | ||
"allow": "all" | ||
}, | ||
{ | ||
|
@@ -28,20 +28,10 @@ | |
"owner": true | ||
}, | ||
{ | ||
"user": "ccx-admin|ccx-reporting-pipeline-trino", | ||
"group": "ccx-datalake-owners", | ||
"schema": "(ccx|ccx_sensitive|ccx_srep|ccx_internal|ccx_workloads)", | ||
"owner": true | ||
}, | ||
{ | ||
"group": "ccx-srep-data-access", | ||
"schema": "ccx_srep", | ||
"owner": true | ||
}, | ||
{ | ||
"user": "ccx-research-pipeline-trino", | ||
"schema": "(ccx|ccx_sensitive)", | ||
"owner": true | ||
}, | ||
{ | ||
"group": "cost-management-team", | ||
"schema": "costmgmt", | ||
|
@@ -144,45 +134,25 @@ | |
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"user": "ccx-admin|ccx-reporting-pipeline-trino", | ||
"group": "ccx-datalake-owners", | ||
"schema": "(ccx|ccx_sensitive|ccx_srep|ccx_internal|ccx_workloads)", | ||
"privileges": ["SELECT", "INSERT", "DELETE", "OWNERSHIP", "GRANT_SELECT"] | ||
}, | ||
{ | ||
"user": "ccx-reporting-pipeline-trino-readonly", | ||
"schema": "(ccx|ccx_sensitive|ccx_srep|ccx_internal|ccx_workloads)", | ||
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"user": "ccx-research-pipeline-trino", | ||
"schema": "(ccx|ccx_sensitive)", | ||
"group": "ccx-internal-data-access", | ||
"schema": "ccx_internal", | ||
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"group": "ccx-dev|assisted-lakers|ccx-datalake-access|ceeandpe|na-cs-tam-auto|apac-cs-tam-auto|latam-cs-tam-auto|emea-cs-tam-auto|na-ps-cs-tam-auto|emea-cs-csm-auto|emea-cs-cse-auto|emea-cs-managers|apac-cs-csm-auto|apac-cs-cse-auto|na-cs-csm-auto|na-cs-cse-auto|na-ps-cs-cse-auto|latam-cs-csm-auto|cs-csa-auto-ccx|ccx-pm|telemeter-auth|telemeter-auto-approval|telemeter-manual-approval|cee-sbr-shift|gcs-csm|asr-insights-dashboards", | ||
"schema": "ccx", | ||
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"user": "superset-ccx", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @accorvin are these superset accounts still used? I didn't find them in Rover There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mbacovsky no, |
||
"schema": "ccx", | ||
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"group": "ccx-dev|assisted-lakers|ccx-sensitive-datalake-access|ceeandpe|na-cs-tam-auto|apac-cs-tam-auto|latam-cs-tam-auto|emea-cs-tam-auto|na-ps-cs-tam-auto|emea-cs-csm-auto|emea-cs-cse-auto|emea-cs-managers|apac-cs-csm-auto|apac-cs-cse-auto|na-cs-csm-auto|na-cs-cse-auto|na-ps-cs-cse-auto|latam-cs-csm-auto|cs-csa-auto-ccx|ccx-pm|telemeter-auth|telemeter-auto-approval|telemeter-manual-approval|cee-sbr-shift|gcs-csm|asr-insights-dashboards", | ||
"schema": "ccx_sensitive", | ||
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"user": "superset-ccx-sensitive", | ||
"schema": "ccx_sensitive", | ||
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"user": "(telemetry-automated|telemetry-edmund-abbot|telemetry-analytics)", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"schema": "ccx|ccx_sensitive", | ||
"privileges": ["SELECT"] | ||
}, | ||
{ | ||
"group": "ccx-srep-data-access", | ||
"schema": "ccx_srep", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we gave ccx-srep-data-access and ccx-research-pipeline-trino ownership of the schemas. Is it needed to sync the partitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either. It seems safe to remove this to me.