Reliably compile z3 for all platforms including Windows #3431
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may wish to try using the The drawback is that github rate limits unauthenticated API access per IP, so in order to use it from a CI pipeline, the CI pipeline must be configured with a readonly github personal access token. I have this set up on the z3.rs repo and it works well; the tokens allow many more requests than even a CI pipeline will realistically use. |
|
hey @ThomasTNO, could you please run scripts/fmt_all.sh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently cmin is only supported for unix. Compilation of Z3 can be challenging. This PR ensures that we can reliably compile Z3 for all platforms including Windows.
Checklist
./scripts/precommit.shand addressed all comments