Move common Clickhouse Server + chdb logic to common superclasses #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move various bits of logic common to both clickhouse server + chdb to new classes from which both specialised versions are derived.
For the
DatabaseAPIs there is still some specialised logic (of course), but theSplinkDataFrames now only differ in the type ofDatabaseAPIthey are dealing with (which is nice).Functionality should remain unchanged, but to clarify matters I have renamed the old
ClickhouseAPIandClickhouseDataFrametoClickhouseServerAPIandClickhouseServerDataFramerespectively (with the old names now being used for these new intermediate classes).