Skip to content

Conversation

@henba1
Copy link
Collaborator

@henba1 henba1 commented Nov 25, 2025

No description provided.

@henba1 henba1 requested review from AWbosman and Aaron99B November 25, 2025 16:21
@henba1 henba1 self-assigned this Nov 25, 2025
@henba1 henba1 added the enhancement New feature or request label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially leave out of mandatory dependencies

if data.dim() == 3:
data = data.unsqueeze(0)

if target.dim() == 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happends when its a targeted attack?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targeted attacks are currently not supported - the target here is the correct label

AttackEstimationModule.verify() currently always passes the true label (verification_context.data_point.label) as the "target"

BinarySearchEpsilonValueEstimator,
)
from ada_verona.verification_module.attack_estimation_module import AttackEstimationModule
from ada_verona.verification_module.attacks.foolbox_attack import FoolboxAttack
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the check whether foolbox is installed like we have for the other scripts

from ada_verona.database.dataset.image_file_dataset import ImageFileDataset
from ada_verona.database.experiment_repository import ExperimentRepository
from ada_verona.dataset_sampler.predictions_based_sampler import PredictionsBasedSampler
from ada_verona.epsilon_value_estimator.binary_search_epsilon_value_estimator import (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need two example scripts for such a small different?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not mandatory though, treat like AutoAttack and AutoVerify\

add check for foolbox like we have for auto-verify and autoattack
@henba1
Copy link
Collaborator Author

henba1 commented Dec 9, 2025

I will check the tests later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants