-
Notifications
You must be signed in to change notification settings - Fork 8
L_2: Introduce metadata part in .vnnlib file to persist image, image_class and epsilon for SDP-CROWN #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…re now part of the VNNLibProperty and can accessed by verifiers that need it as part of a sidecar metadata
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Aaron99B
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is already included in the verification context in the data point. Why do we need it another time?
VerificationContext is VERONA-internal state by design of the current auto_verify_module.py, which from verification_context only passes along verification_context.network.path to the verifier via verify_property(...). Recall that auto-verify verifier API is But SDP-CROWN needs image, image_class/label and epsilon. Thats why we attach it to VNNLib_property |
|
Can't we include SDP-Crown using a different interface? I would refrain from putting the same image twice in the verification context |
…erification_module more general by including data other than image data
Introduce VNNLib sidecar for SDP-CROWN that carries image and image_class.
For SDPCrown, carrying the image alongside the VNNLIB property is the cleaner and less error‑prone design than trying to reconstruct a BoundedTensor inside SDP-CROWN from the VNNLIB text.