Fix android tests #136
Open
Fix android tests #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They had been silently ignored on our CI. Test resources are duplicated in src/androidInstrumentedTest/assets and src/commonTest/resources for now until we find a way to share them.
This fixes `WARNING: D8: Unexpected error during rewriting of Kotlin metadata for class` when building the android library.
Closed
|
There are no functional changes, and build changes are limited to Android. I've checked that the Android library is valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have broken them during a recent update to the build scripts and they had been silently ignored on our CI, which can be seen when running
gradlew connectedCheck --info, it will show:Skipping task ':jni:android:connectedCheck' as it has no actions.To verify that the problem has been fixed, start en emulator and run
gradlew connectedCheck, you will see:Test resources are duplicated in src/androidInstrumentedTest/assets and src/commonTest/resources for now until we find a way to share them.