Skip to content

Update for taproot channels #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 23, 2025
Merged

Update for taproot channels #758

merged 8 commits into from
Oct 23, 2025

Conversation

@dpad85
Copy link
Member

@dpad85 dpad85 commented Oct 15, 2025 •
edited
Loading

This PR updates to the latest lightning-kmp snapshot version, which brings taproot channels into Phoenix, as well as other fixes and improvements.

Notable PRs:

funding and closing transactions become cheaper (by about 15%)
on-chain footprint becomes more private: funding and closing transactions are impossible to distinguish from other p2tr transactions.

Notes:

  • For additional details about taproot channels, see extension-bolt: simple taproot channels (feature 80/81) lightning/bolts#995.
  • no specific code was needed in Phoenix to support taproot channels, the work has already been done in lightning-kmp. Most of the code changes in this PR come from various refactoring, fixes, an upgrade to the kotlin version, and code cleanup.
  • support for legacy channel data import has been removed from lightning-kmp and consequently, the import channel data screens must be removed from Phoenix.
  • he spend-from-channel-address screen does not work anymore with taproot channels so this screen is disabled for the time being.

dpad85 and others added 5 commits October 15, 2025 13:58
@dpad85
Update to lightning-kmp taproot-channel version
28cf92e 
This version also updates kotlin and cleans up legacy code.

Notably, the tools for the legacy channel data backup have been
removed, and the import-channel-data helper can be removed.

The spend-from-channel-address helper has been commented out as
it is not ready with taproot-channels yet.
@dpad85
(android) Update android app with latest lightning-kmp
94db39f 
This includes removing the obsolete import-channel-data screen
and string resources.
@robbiehanson
(ios) Fixing compiler issues, and removing dead code
3b8cecf
@robbiehanson
Fixing several issues regarding OfferPaymentMetdata V1 vs V2
c2127a9
@dpad85
Use abstract payerKey and payerNote in offer metadata
4438d08 
See ACINQ/lightning-kmp#821

Also limit the description input to 64 chars for Bolt12 offers
as the description + payer note cannot exceed 64 chars.
@dpad85 dpad85 marked this pull request as ready for review October 17, 2025 17:13
@dpad85 dpad85 requested a review from robbiehanson October 17, 2025 17:13
@dpad85
(android) Disable spend-from-channel-address screen
1de8819 
Also removed unused resources used by the import-channel screen.
@robbiehanson
Copy link
Contributor

Also limit the description input to 64 chars for Bolt12 offers

Looks like we were already doing this on iOS:

phoenix/phoenix-ios/phoenix-ios/views/send/ValidateView.swift

Line 1538 in 56fbe17

maxCommentLength = 64

@dpad85 dpad85 merged commit bc3e657 into master Oct 23, 2025
@dpad85 dpad85 deleted the update-lnkmp-1.11 branch October 23, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robbiehanson robbiehanson robbiehanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpad85 @robbiehanson