geomap draft #30
Draft
geomap draft #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for issue #25. What I have so far on this branch is a toggle button for displaying or hiding a geomap that renders on a background layer, with multiple copies of the svg rendered at specific coordinates, defined by geohashes. There are some problems though, and some may be caused by code not specific to this branch. When dynamically increasing/decreasing the amount of SVGs that are rendered by changing the data, sometimes a runtime error is thrown in the console from react source. This has proved very difficult to debug and I think it may be valuable to update react to the latest version and possibly make a switch to functional components before debugging further. I also recall running into cases where the SVGs were not animating properly, which I believe is not specific to this branch and could be related to #29 and/or #23. I did experience some cases where my browser tab has crashed while working on this branch as well which I am unsure what the cause is or if it is specific to this branch. The main planned features that are missing from this branch are exposing SVG data so it can be accessed in the user generated code, and implementing camera movement so that marked points on the geomap are zoomed toward initially.