Change buffer size to 100 MB in read_chunked.c#56
Merged
manodeep merged 1 commit intoACCESS-NRI:mainfrom Dec 17, 2025
Merged
Conversation
Collaborator
Author
|
Fixes #55 |
Collaborator
Author
|
The CI failure seems to be for a different reason. |
Collaborator
Author
|
I can't request a review either - @dougiesquire will you please take a look? |
dougiesquire
approved these changes
Dec 17, 2025
Collaborator
dougiesquire
left a comment
dougiesquire
left a comment
There was a problem hiding this comment.
The CI failure seems to be for a different reason.
This is because your PR is from a fork. Happy to approve but I can also give you write access in the future
Thanks @manodeep
Collaborator
Author
|
Thanks @dougiesquire! Yes, it would be good for me to have write access to a repo with C code :) - did you want me to put the request in the Zulip topic? |
Collaborator
Just added you - no need for Zulip :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the bitwise XOR (which was allocating a 1027B buffer) with a 100 MB buffer