Skip to content

Fix readthedocs#52

Merged
dougiesquire merged 2 commits intomainfrom
readthedocs
Aug 5, 2025
Merged

Fix readthedocs#52
dougiesquire merged 2 commits intomainfrom
readthedocs

Conversation

@dougiesquire
Copy link
Copy Markdown
Collaborator

@dougiesquire dougiesquire commented Aug 5, 2025

No description provided.

@dougiesquire dougiesquire force-pushed the readthedocs branch 2 times, most recently from 98bc6e5 to 438c951 Compare August 5, 2025 01:58
chrisb13
chrisb13 previously approved these changes Aug 5, 2025
View reviewed changes
Copy link
Copy Markdown

@chrisb13 chrisb13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this kind of deployment of RTD but it LGTM.

Side note: do we really want to be maintaining both RTD and mkdoc systems? I'm aware that the template for mkdocs is coming (@atteggiani) ... I guess in this case, the RTD docs have existed for a while?

(Is there a working pr-preview you can point towards? I guess it needs this stuff first.)

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

dougiesquire commented Aug 5, 2025

Thanks @chrisb13. We have taken over ownership of this project from clex. This PR is just fixing/updating the existing docs (which were last deployed successfully 6 years ago).

The preview can be found in the checks section at the bottom of the page. Click on "docs/readthedocs.org:mppnccombine-fast".

I've also just added some status badges to the README. Could you please re-approve?

chrisb13
chrisb13 approved these changes Aug 5, 2025
View reviewed changes
Copy link
Copy Markdown

@chrisb13 chrisb13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this and this look ok (badges!).

@dougiesquire dougiesquire merged commit 628629e into main Aug 5, 2025
2 checks passed
@dougiesquire dougiesquire deleted the readthedocs branch August 5, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chrisb13 chrisb13 chrisb13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dougiesquire @chrisb13