Merged
Conversation
Member
|
My preference, if this is suitable, is to merge and add more bells and whistles later if required. Not only does that get it deployed more quickly, but it also serves as a minimal example that others can just copy/cherry-pick. |
Member
Author
Member
Author
|
@dougiesquire is this a kind of package that would benefit from having all the same compiler down the dependency chain, or does it not matter as much? |
Collaborator
|
I'm not sure sorry. I don't really understand when this is/isn't a good idea? My guess is that it's less important here, so maybe we start without and see how we go? |
Member
Author
|
Done in 56b1154 @dougiesquire |
dougiesquire
approved these changes
Jul 30, 2025
Collaborator
dougiesquire
left a comment
There was a problem hiding this comment.
Thanks @CodeGat - LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Background
Here is an initial implementation of
build-cifor this repository. It contains a simple install test, found in.github/build-ci/manifests/spack.yaml.j2. More can be added, and more can be done in parallel, with either a matrix or multiple jobs. `