Skip to content

Add basic manifest and CI#50

Merged
CodeGat merged 3 commits intomainfrom
47-build-ci
Jul 30, 2025
Merged

Add basic manifest and CI#50
CodeGat merged 3 commits intomainfrom
47-build-ci

Conversation

@CodeGat
Copy link
Copy Markdown
Member

@CodeGat CodeGat commented Jul 25, 2025

Closes #47

Background

Here is an initial implementation of build-ci for this repository. It contains a simple install test, found in .github/build-ci/manifests/spack.yaml.j2. More can be added, and more can be done in parallel, with either a matrix or multiple jobs. `

@CodeGat CodeGat self-assigned this Jul 25, 2025
@aidanheerdegen
Copy link
Copy Markdown
Member

My preference, if this is suitable, is to merge and add more bells and whistles later if required.

Not only does that get it deployed more quickly, but it also serves as a minimal example that others can just copy/cherry-pick.

@CodeGat
Copy link
Copy Markdown
Member Author

CodeGat commented Jul 28, 2025

https://github.com/ACCESS-NRI/mppnccombine-fast/actions/runs/16557063923/job/46820064243?pr=50 2 minute CI 🥹

@CodeGat CodeGat marked this pull request as ready for review July 28, 2025 00:31
@CodeGat
Copy link
Copy Markdown
Member Author

CodeGat commented Jul 30, 2025

@dougiesquire is this a kind of package that would benefit from having all the same compiler down the dependency chain, or does it not matter as much?

@dougiesquire
Copy link
Copy Markdown
Collaborator

dougiesquire commented Jul 30, 2025

I'm not sure sorry. I don't really understand when this is/isn't a good idea?

My guess is that it's less important here, so maybe we start without and see how we go?

Copy link
Copy Markdown
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CodeGat!

Code you please also remove the .travis.yml file and remove this line from the README.md? Then I think this PR can close #47

@CodeGat
Copy link
Copy Markdown
Member Author

CodeGat commented Jul 30, 2025

Done in 56b1154 @dougiesquire

Copy link
Copy Markdown
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CodeGat - LGTM

@CodeGat CodeGat merged commit 7f4ff87 into main Jul 30, 2025
1 check passed
@CodeGat CodeGat deleted the 47-build-ci branch July 30, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build CI

3 participants