Skip to content

Conversation

@manodeep
Copy link
Collaborator

Details for the optimised build are in this issue. This corresponded to build 4, but I have created a new branch and attempted to follow the branch-naming guidelines.

Should be squash-merged, and once this is merged, the original update_compiler_flags branch can be deleted.

@manodeep manodeep requested review from Whyborn and penguian January 30, 2026 05:20
Copy link
Collaborator

@penguian penguian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with these changes, as long as they have been tested and shown to run correctly.

@aidanheerdegen
Copy link
Member

Tested bit repro in this PR

ACCESS-NRI/ACCESS-ESM1.6#181 (comment)

with this PR build

ACCESS-NRI/ACCESS-ESM1.6#181 (comment)

I checked build logs and they have the modified flags

mpif90 -o overlap_mix_maximum.o -I/scratch/tm70/tm70_ci/tmp/restricted/spack-stage/spack-stage-um7-git.2025.12.000_access-esm1.6-oz4papayiyljxealpwptlbgzzd56wdyp/spack-src/ummodel_hg3/inc -I/scratch/tm70/tm70_ci/tmp/restricted/spack-stage/spack-stage-um7-git.2025.12.000_access-esm1.6-oz4papayiyljxealpwptlbgzzd56wdyp/spack-src/umbase_hg3/inc -O2 -unroll  -g   -traceback   -i8 -r8      -fp-model precise -ftz -what -fno-alias -stack-temps -safe-cray-ptr -c /scratch/tm70/tm70_ci/tmp/restricted/spack-stage/spack-stage-um7-git.2025.12.000_access-esm1.6-oz4papayiyljxealpwptlbgzzd56wdyp/spack-src/ummodel_hg3/ppsrc/atmosphere/radiation_service/overlap_mix_maximum.f90

So good to merge and tag

@aidanheerdegen aidanheerdegen merged commit 1b00167 into main Jan 30, 2026
3 checks passed
@manodeep
Copy link
Collaborator Author

manodeep commented Feb 1, 2026

Thanks @aidanheerdegen and @penguian !

@manodeep manodeep deleted the 375_update_um7_flags branch February 1, 2026 22:35
aidanheerdegen added a commit that referenced this pull request Feb 2, 2026
aidanheerdegen added a commit that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants