-
Notifications
You must be signed in to change notification settings - Fork 7
Changes required to use CABLE as a library for ESM1.6 #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@harshula Could I get your assistance debugging this failure: I'm trying to work out the CABLE CI failure- says edit: Worked out the problem, I was misusing the |
|
@penguian as per the conversation in the ESM1.6 meeting this morning, the GCC build failures should not block merging. Further, we've removed the GCC build from UM7's build CI. |
|
Oops, sorry I realised that was intentional. |
SeanBryan51
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, no need to address my suggestion to expose CABLE specifics through a single module in this PR since its a pretty big change. But it would be great if that was put in later IMO.
|
I don't have write access, @harshula could you give this a review? |
|
HI @SeanBryan51 , I've given you write access. |
penguian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try changing ESM1.6 to access-esm1.6
|
I've pushed the changes- the CI will fail on CABLE until this CABLE PR is merged (I think?). |
# CABLE Update name specification of library to "access-esm1.6" as per [this spack-packages PR](ACCESS-NRI/access-spack-packages#340), for consistency with other models. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--646.org.readthedocs.build/en/646/ <!-- readthedocs-preview cable end -->
penguian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
* Add library variant to the CABLE spack package, which specifies the coupled application to compile for. Use with when in the UM7 spack package to include the CABLE library when access-esm1.6." * Disable default CI. The GCC compile that would fail because of GCOM4.
Associated PR in ESM1.6 that shows bitwise compatibility with non-library build: ACCESS-NRI/ACCESS-ESM1.6#156
UM PR that removes the CABLE code: https://github.com/ACCESS-NRI/UM7/pull/176
The implementation in the UM7 spack package feels quite clunky but I couldn't think of a better way to do it. Happy to hear suggestions on how to improve it.