Skip to content

Conversation

@Whyborn
Copy link
Collaborator

@Whyborn Whyborn commented Oct 26, 2025

Associated PR in ESM1.6 that shows bitwise compatibility with non-library build: ACCESS-NRI/ACCESS-ESM1.6#156
UM PR that removes the CABLE code: https://github.com/ACCESS-NRI/UM7/pull/176

The implementation in the UM7 spack package feels quite clunky but I couldn't think of a better way to do it. Happy to hear suggestions on how to improve it.

@Whyborn
Copy link
Collaborator Author

Whyborn commented Oct 26, 2025

@harshula Could I get your assistance debugging this failure: I'm trying to work out the CABLE CI failure- says cannot satisfy [email protected], but it builds with no problems in this ESM1.6 PR which uses that spec. I'm expecting the UM7 build failure, as the CI will be trying to build with CABLE as library while still having it as source code, UM7 PR is here.

edit: Worked out the problem, I was misusing the with when functionality.

@Whyborn
Copy link
Collaborator Author

Whyborn commented Oct 27, 2025

@penguian as per the conversation in the ESM1.6 meeting this morning, the GCC build failures should not block merging. Further, we've removed the GCC build from UM7's build CI.

@Whyborn Whyborn requested a review from SeanBryan51 October 29, 2025 00:49
@SeanBryan51
Copy link
Collaborator

SeanBryan51 commented Oct 29, 2025

"Add UM7 intel specific CI to bypass gcc" - I would have thought we want to keep the GCC test case, do you know why the GCC build was failing?

Oops, sorry I realised that was intentional.

SeanBryan51
SeanBryan51 previously approved these changes Oct 29, 2025
Copy link
Collaborator

@SeanBryan51 SeanBryan51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, no need to address my suggestion to expose CABLE specifics through a single module in this PR since its a pretty big change. But it would be great if that was put in later IMO.

@SeanBryan51
Copy link
Collaborator

I don't have write access, @harshula could you give this a review?

@harshula
Copy link
Collaborator

HI @SeanBryan51 , I've given you write access.

Copy link
Collaborator

@penguian penguian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try changing ESM1.6 to access-esm1.6

@Whyborn
Copy link
Collaborator Author

Whyborn commented Oct 29, 2025

I've pushed the changes- the CI will fail on CABLE until this CABLE PR is merged (I think?).

Whyborn added a commit to CABLE-LSM/CABLE that referenced this pull request Oct 30, 2025
# CABLE

Update name specification of library to "access-esm1.6" as per [this
spack-packages
PR](ACCESS-NRI/access-spack-packages#340), for
consistency with other models.


<!-- readthedocs-preview cable start -->
----
📚 Documentation preview 📚:
https://cable--646.org.readthedocs.build/en/646/

<!-- readthedocs-preview cable end -->
@Whyborn Whyborn requested a review from penguian October 30, 2025 02:22
Copy link
Collaborator

@penguian penguian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@Whyborn Whyborn merged commit 5209e65 into main Oct 31, 2025
8 of 9 checks passed
harshula pushed a commit that referenced this pull request Oct 31, 2025
* Add library variant to the CABLE spack package, which specifies the
  coupled application to compile for. Use with when in the UM7 spack
  package to include the CABLE library when access-esm1.6."

* Disable default CI. The GCC compile that would fail because of GCOM4.
@harshula
Copy link
Collaborator

Hi @Whyborn & @penguian ,

re: #372

@penguian did extensive testing of with when(). We should only use it in the member variable declaration area of the class for conditional depends_on() calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants