Conversation
|
Contributes to ACCESS-NRI/access-om3-configs#346 |
|
This is still a draft but is ready for a review for style / approach. I've only implemented for CICE6 at this point, see the example deployment in ACCESS-NRI/ACCESS-OM3#35 |
aidanheerdegen
left a comment
There was a problem hiding this comment.
I have pending comments, so had to submit a review for some reason.
dougiesquire
left a comment
There was a problem hiding this comment.
Fixes for failing linting checks
Co-authored-by: Dougie Squire <[email protected]>
Co-authored-by: Dougie Squire <[email protected]>
dougiesquire
left a comment
There was a problem hiding this comment.
This looks good from my perspective, thanks @anton-seaice. My preference is to wait for approval from @aidanheerdegen before merging, particularly in regards to the setting of versions.
|
Last call for reviews @aidanheerdegen and @harshula :) |
harshula
left a comment
There was a problem hiding this comment.
- Docstring line length should be reduced. i.e. https://peps.python.org/pep-0008/#maximum-line-length
- Should the variant
access3in all the SPRs have a consistently worded descriptions?
I made some changes for these - let me know if I missed anything |
aidanheerdegen
left a comment
There was a problem hiding this comment.
One question, otherwise happy for you to merge.
One point for a possible future change is to keep all the common depends_on logic in a single place and include them into the packages. I guess a mixin class?
dougiesquire
left a comment
There was a problem hiding this comment.
I resolved some review comments that I started, but there are still a few others started by others that I didn't feel qualified to resolve
This is an extremely draft collection of changes to
spack-packagesto build OM3 by component.I've been building access3-share with '+install_libraries' in the spec, I haven't looked at building with an executable yet
I've been using these git versions :
https://github.com/ACCESS-NRI/CICE/tree/5-port_cmake_build
and
https://github.com/ACCESS-NRI/access3-share/tree/share_prototype
Example deployment: ACCESS-NRI/ACCESS-OM3#35