Skip to content

Support builds with all ACCESS types#37

Merged
dougiesquire merged 3 commits intodevelopmentfrom
dougiesquire/development
Apr 17, 2025
Merged

Support builds with all ACCESS types#37
dougiesquire merged 3 commits intodevelopmentfrom
dougiesquire/development

Conversation

@dougiesquire
Copy link
Copy Markdown
Collaborator

Also removed the generic tracers git submodule, which will no longer be needed

@dougiesquire dougiesquire requested a review from harshula April 16, 2025 05:52
@harshula harshula requested a review from aidanheerdegen April 16, 2025 05:57
Copy link
Copy Markdown
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to add a comment, up to you.

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

Note, please do not merge this. This compiles, but the legacy ACCESS-OM-BGC type segfaults when run. So I still have some work to do here.

@aidanheerdegen aidanheerdegen marked this pull request as draft April 16, 2025 23:33
@aidanheerdegen
Copy link
Copy Markdown
Member

Note, please do not merge this

I have converted to draft.

@dougiesquire dougiesquire force-pushed the dougiesquire/development branch from ed9eadc to 6df3084 Compare April 17, 2025 00:33
@dougiesquire
Copy link
Copy Markdown
Collaborator Author

Okay, I've tested the changes in this PR in our different models use prereleases and the repro testing CI:

Model Configuration tested Historical reproducibility
ACCESS-OM2

dev-1deg_jra55_ryf

dougiesquire/1deg_jra55_ryf_wombatlite

❌ Test PR here

❌ Test PR here

ACCESS-OM2-BGC (legacy) dev-1deg_jra55_ryf_bgc ✅ Test PR here
ACCESS-ESM1.6 dev-preindustrial+concentrations ✅ Test PR here

The answer changes to the ACCESS-OM2+WOMBATlite configuration are only in WOMBAT tracers and are due to updates to WOMBATlite since the config was last updated.

Similarly, I think the answer changes to the ACCESS-OM2 configuration come from previous changes on the MOM5 development branch, not the changes in this PR (namely, the changes in this PR).

So I believe this is ready to merge.

(Note, these tests required changes to the MOM5 SPR. I used this branch, but @harshula is working on a better implementation of the functionality in that branch.)

@dougiesquire dougiesquire marked this pull request as ready for review April 17, 2025 04:49
@dougiesquire
Copy link
Copy Markdown
Collaborator Author

@aidanheerdegen would you mind taking another quick look?

This is what has changed since you last looked: I added back in the allocation of some arrays so that we can build with legacy WOMBAT if we want to (using the ACCESS-OM-BGC build type)

Copy link
Copy Markdown
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though I must admit to being a bit confused by all the simultaneous changes ...

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

Looks fine to me, though I must admit to being a bit confused by all the simultaneous changes ...

Yeah, there are a lot of dependent changes taking place

@dougiesquire dougiesquire merged commit 8f53180 into development Apr 17, 2025
@dougiesquire dougiesquire deleted the dougiesquire/development branch April 17, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants