Support builds with all ACCESS types#37
Conversation
aidanheerdegen
left a comment
There was a problem hiding this comment.
Suggest to add a comment, up to you.
|
Note, please do not merge this. This compiles, but the legacy |
I have converted to draft. |
ed9eadc to
6df3084
Compare
|
Okay, I've tested the changes in this PR in our different models use prereleases and the repro testing CI:
The answer changes to the ACCESS-OM2+WOMBATlite configuration are only in WOMBAT tracers and are due to updates to WOMBATlite since the config was last updated. Similarly, I think the answer changes to the ACCESS-OM2 configuration come from previous changes on the MOM5 So I believe this is ready to merge. (Note, these tests required changes to the MOM5 SPR. I used this branch, but @harshula is working on a better implementation of the functionality in that branch.) |
|
@aidanheerdegen would you mind taking another quick look? This is what has changed since you last looked: I added back in the allocation of some arrays so that we can build with legacy WOMBAT if we want to (using the |
aidanheerdegen
left a comment
There was a problem hiding this comment.
Looks fine to me, though I must admit to being a bit confused by all the simultaneous changes ...
Yeah, there are a lot of dependent changes taking place |
Also removed the generic tracers git submodule, which will no longer be needed