forked from ESCOMP/CMEPS
-
Notifications
You must be signed in to change notification settings - Fork 0
CM3 change rc cmeps1.1.31 x #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kieranricardo
wants to merge
42
commits into
cmeps1.1.35-x
Choose a base branch
from
cm3-change-rc-cmeps1.1.31-x
base: cmeps1.1.35-x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 20 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
f0f03c7
add access coupling options
458a277
add access field exchange module
5ce16a5
add ice to um fields
kieranricardo 641f21d
update access fld exchange module to new CMEPS
33eee80
typo fix
76c9db9
bufix: fixed syntax errors
kieranricardo 197998e
bufix: fixed syntax errors
kieranricardo 0725174
more logging
kieranricardo c91eabc
update CM3 CMEPS to 1.1.2
kieranricardo 3f980c7
fix fields
kieranricardo 21bb9ce
change flux scaling
kieranricardo 9b8b24d
scale precipitation over ocean by ocean fraction
kieranricardo 3eea31f
remove scaling of ice->ocn fluxes by ice fraction (scaling now in CIC…
kieranricardo 0e3c454
fix precipitation merge
kieranricardo 2e7db88
add iceberg fluxes
kieranricardo 1fa72ee
add ocean current coupling
kieranricardo fc6754c
Don't run custom CESM calculations for access
blimlim db26dc0
Tidy old logging code and comments
blimlim 996d166
Implement time-travelling ice in post atm
kieranricardo 63e4c6d
map wind stress atm->ocn with patch interpolation
kieranricardo 06629b2
Update mediator/esmFldsExchange_access_mod.F90
kieranricardo 5eea76b
Update mediator/esmFldsExchange_access_mod.F90
kieranricardo 7c61389
Update mediator/esmFldsExchange_access_mod.F90
kieranricardo da756ff
- check array in time travelling ice routine
kieranricardo a169525
add missing import
kieranricardo f029178
field name changes
kieranricardo 6cf9974
revert CMakeLists.txt and Makefile
kieranricardo 7bc2df0
check ice_frac_cat_ptr > 1e-11 (puny) before division
kieranricardo c9e2fae
update coupled names in post_atm tti
kieranricardo 19e77ae
update coupling mode check
kieranricardo 24e5ff0
Indent changes
kieranricardo ec8cccc
Delete duplicate rainc and snowc
kieranricardo 70deab3
fix comments
kieranricardo 8578c31
fix indentation
kieranricardo e261526
rename `access->accessesm`
kieranricardo e712bea
delete fieldcheck
kieranricardo 929fe0f
delete unecessary fields going into CICE
kieranricardo 581dc2e
add fieldchecks around re-mapping
kieranricardo 87dde08
fix syntax errors
kieranricardo 1488879
fix import error
kieranricardo fa99a31
fix import error
kieranricardo 6501f8c
map wind stress to sea-ice and remove atm->ice state fields
kieranricardo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this file, so possibly this is confusing (
[esmFldsExchange_hafs_mod.F90](https://github.com/ACCESS-NRI/CMEPS/blob/upstream-main/mediator/esmFldsExchange_hafs_mod.F90)isn't included, for example)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to be able to use the same version of CMEPS in CM3 and OM3, but this CMakeList.txt is overridden in
access3-shareanyway, so I could put the change there. What do you think? Then we have a mediator that can compute both CM3 and OM3 fluxes.