Skip to content

Work towards adding interaction between the flatmap and the simulation vuers.#462

Draft
hsorby wants to merge 23 commits intomainfrom
simulation-interaction
Draft

Work towards adding interaction between the flatmap and the simulation vuers.#462
hsorby wants to merge 23 commits intomainfrom
simulation-interaction

Conversation

@hsorby
Copy link
Copy Markdown
Contributor

@hsorby hsorby commented Jan 13, 2026

No description provided.

@agarny
Copy link
Copy Markdown

agarny commented Mar 4, 2026

@hsorby / @alan-wu: I believe I am done with the interaction between the flatmap and SimulationVuer. I have released version 3.0.10 of SimulationVuer.

FlatmapSimulationVuerInteraction.mp4

@agarny
Copy link
Copy Markdown

agarny commented Mar 4, 2026

Oops, I have just realised that in SimulationVuer's removeDataSubscription() exposed method, I update the activeSubscriptions array, but I forgot to tell OpenCOR to stop tracking some simulation data. So, yes, I need to "fix" this, which is going to mean a new version of SimulationVuer sometime this morning and MAPIntegratedVuer to use that new version... 🤦‍♂️

@agarny
Copy link
Copy Markdown

agarny commented Mar 4, 2026

@hsorby / @alan-wu / @nickerso

Ok, I have updated SimulationVuer and released version 3.0.11, and updated this PR as a result. I believe I am all done for now (for now because of my first bullet point below).

Otherwise:

  • When switching protocols, we should send a message to SimulationVuer (something like removeAllDataSubscriptions()), so that it doesn't unnecessarily keep track of things that may not be relevant anymore.
  • Say that several plotting windows are opened, then whenever I click on the titlebar of one them I would expect that plotting window to be on top of everything, but it's not. The "top" plotting window is the one that was opened last and that is it.
  • There are some styling issues in the Available Protocols sidebar (see below; font family and test colour). Otherwise, I am not sure about the Available Protocols name, not least since we have a button that reads Open Simulation.
Screenshot 2026-03-05 at 11 53 49 Screenshot 2026-03-05 at 11 54 03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants