Single listing with SCKAN as the primary listing#326
Merged
alan-wu merged 14 commits intoABI-Software:mainfrom Mar 18, 2026
Merged
Single listing with SCKAN as the primary listing#326alan-wu merged 14 commits intoABI-Software:mainfrom
alan-wu merged 14 commits intoABI-Software:mainfrom
Conversation
This was referenced Feb 23, 2026
alan-wu
reviewed
Mar 17, 2026
src/services/flatmapQueries.js
Outdated
Comment on lines
+328
to
+329
| connectivitySource = isCq27ServiceAvailable ? 'sckan' : connectivitySource; | ||
| this.connectivitySource = isCq27ServiceAvailable ? 'sckan' : connectivitySource; |
Member
There was a problem hiding this comment.
Is there a reason there are two lines here with one overwriting the argument?
Member
Author
There was a problem hiding this comment.
Thanks, it shouldn't be that way.
I've fixed it now in 9d26706.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (work-in-progress) pull request is a part of
https://github.com/ABI-Software/mapcore-issues/issues/124
Related pull requests