Skip to content

update tutorial 2#105

Open
JialiXu12 wants to merge 19 commits intoABI-CTT-Group:mainfrom
JialiXu12:main
Open

update tutorial 2#105
JialiXu12 wants to merge 19 commits intoABI-CTT-Group:mainfrom
JialiXu12:main

Conversation

@JialiXu12
Copy link
Copy Markdown
Collaborator

Description:

Describe what changes you are adding

Related issue(s):

Mention related issues

Test Environment:

Specify the testing enviroment. e.g. OS, Python version

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PrasadBabarendaGamage
Copy link
Copy Markdown
Collaborator

Hi all, seems like there are some changes that need to be pulled in for tutorial 2? @JialiXu12 Just checking if this includes changes that were made during the workshop? I think I already committed most of these changes already - ie removing zip files etc and uploading the raw dataset. So think it’s only the changes that were made during the workshop that are missing. @LIN810116 I think you committed something too - are they the same changes here?

@chinchien-lin
Copy link
Copy Markdown
Contributor

Hi @JialiXu12 ,
I think some changes in this PR have been merged via other PRs. Some have been done by @PrasadBabarendaGamage 's commits. The latest Tutorial 2 has also been merged during the workshop by PR #106
@JialiXu12 Hoping you can check this again and make another PR for other changes that have not been merged.
You can do this by :

  • Pulling the latest version.
  • if there are any conflicts, please solve them locally
  • then submit a new PR

@PrasadBabarendaGamage
Copy link
Copy Markdown
Collaborator

Thanks all - one thing noticed was that there is some jupyter notebook cell output that is included in the commits. We just need to remember to clear all outputs before committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants