Repository navigation
Run TestPyPI rehearsal after successful builds - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
The authorized manual rehearsal run 39069235921 built all four wheels successfully but skipped the testpypi job. The tag-only receipt job was intentionally skipped; GitHub propagated that skipped ancestor through the dependency chain under the implicit success condition. No package was uploaded. All four wheels and the sdist were retained and their SHA256 manifests checked.
Fix
Give testpypi an explicit non-cancelled status condition AND require needs.build.result to equal success. Failed/cancelled builds cannot upload, the protected testpypi reviewer gate remains intact, and production remains tag-only.
Validation
Use a merge commit to preserve receipt ancestry. A fresh manual rehearsal after merge will validate that the human approval gate is reached; do not treat the earlier build-only run as an upload.