Skip to content

Add a CI script to run setup_python.sh#1

Merged
matthewsot merged 10 commits intomasterfrom
matthew-add-ci
Aug 22, 2020
Merged

Add a CI script to run setup_python.sh#1
matthewsot merged 10 commits intomasterfrom
matthew-add-ci

Conversation

@matthewsot
Copy link
Copy Markdown
Contributor

This PR adds a CI script to ensure that setup_python.sh runs without error. It will probably need some debugging, hence opening this PR as a draft for now.

@matthewsot matthewsot self-assigned this Aug 21, 2020
@matthewsot matthewsot marked this pull request as ready for review August 21, 2020 21:33
@matthewsot
Copy link
Copy Markdown
Contributor Author

@adityathakur PTAL. It tests the installation on four operating systems, macOS 10.15 + 4 recent versions of Ubuntu. It looks like the Github runner's Ubuntu image comes with the necessary libraries for ssl and they're picked up automatically. Of course, macOS is always quite a bit more of a pain to deal with :) but this approach seems to work.

Copy link
Copy Markdown

@adityathakur adityathakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This looks great!

@matthewsot
Copy link
Copy Markdown
Contributor Author

To resolve our discussion yesterday, in 03b1ab4 I added a check directly into the setup_python.sh script which warns the user if the ssl or zlib modules weren't loaded (these seem to be the most popular optional modules). I also modified the README to give explicit instructions for macOS. Will merge once the last check passes!

@matthewsot matthewsot merged commit 3691134 into master Aug 22, 2020
@matthewsot matthewsot deleted the matthew-add-ci branch August 22, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants