Skip to content

Conversation

@MollieS
Copy link

@MollieS MollieS commented Oct 11, 2016

  • Ensures a response for a partial get request has a date header and date

Copy link
Member

@damonkelley damonkelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add this, but we might want to tweak it first. The spec indicates that this field is only required when the Date header is also included in the response when the entire resource is requested. We are not checking for the Date header for any other resources, so it feels a little weird to only check for it in a partial content response.

When a 206 response is generated, the server MUST generate the
following header fields, in addition to those required above, if the
field would have been sent in a 200 (OK) response to the same
request: Date, Cache-Control, ETag, Expires, Content-Location, and
Vary.

https://tools.ietf.org/html/rfc7233#section-4.1

@damonkelley
Copy link
Member

I am trying to get take care of this backlog of PRs that we have accumulated. I acknowledge that this PR was opened ~1.5 years ago, so if you think you are not going to be able to move this PR forward, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants