Conversation
pparkjs
approved these changes
Jan 28, 2025
Collaborator
pparkjs
left a comment
pparkjs
left a comment
There was a problem hiding this comment.
어드민에도 드디어 인증이!!
관리자 변경 로그를 위한 필드 추가도 탁월한 선택이였습니다 수고하셨어요 ㅎㅎ
Comment on lines
+53
to
+58
| public Notice(NoticeType type, NoticeTitle title, NoticeDescription description, Admin createAdmin) { | ||
| this.type = type; | ||
| this.title = title; | ||
| this.description = description; | ||
| this.createAdmin = createAdmin; | ||
| this.lastUpdateAdmin = createAdmin; |
Collaborator
There was a problem hiding this comment.
맞아요 어드민은 무조건 어떤 관리자가 수정했는지 기록이 남아야한다고 하더라고여 책임 때문에
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notice와 Topic 관련, 어드민 전용 API에 인증 로직을 적용했습니다.
Controller에서
@Auth를 적용해서 인증 로직을 타도록 했습니다.인증만하고 끝내기는 심심해서 Notice의 경우에는
createAdmin과lastUpdateAdmin필드를 추가하여 누가 생성하고 마지막으로 수정했는지 기록을 남도록 구현했습니다.Topic은 관리자의 정보를 저장해도 유용하지 않을 것 같아 그냥 두었습니다.
Relation Issues