Skip to content

Error Handling und Ausgabe ohne msg und/oder format bei allen Nodes möglich #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Error Handling und Ausgabe ohne msg und/oder format bei allen Nodes möglich #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
213c785
Remove msg and format from start-process init token; error handling i…
moellenbeck Jan 15, 2025
03045bb
remove async in on close of wait-for-usertask
roblen45 Jan 15, 2025
054f707
Add await on subscribe in wait-for-usertask; Add .catch for all regis…
moellenbeck Jan 15, 2025
c321746
Finish node.error(error, {}) handling; add tests for other node-types
moellenbeck Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM nodered/node-red:4.0.2
FROM nodered/node-red:4.0.8

RUN npm install node-red-debugger@^1.1.1

Expand Down
8 changes: 5 additions & 3 deletions endevent-finished-listener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = function (RED) {
const client = node.engine.engineClient;

if (!client) {
node.error('No engine configured.');
node.error('No engine configured.', {});
return;
}

Expand All @@ -21,7 +21,7 @@ module.exports = function (RED) {
});
});
} catch (error) {
node.error(JSON.stringify(error));
node.error(error, {});
}

node.on('close', async () => {
Expand All @@ -32,7 +32,9 @@ module.exports = function (RED) {
};

if (node.engine) {
register();
register().catch((error) => {
node.error(error, {});
});
}
}
RED.nodes.registerType('endevent-finished-listener', EndEventFinishedListener);
Expand Down
6 changes: 4 additions & 2 deletions externaltask-event-listener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = function (RED) {
const client = node.engine.engineClient;

if (!client) {
node.error('No engine configured.');
node.error('No engine configured.', {});
return;
}

Expand Down Expand Up @@ -51,7 +51,9 @@ module.exports = function (RED) {
};

if (node.engine) {
register();
register().catch((error) => {
node.error(error, {});
});
}
}
RED.nodes.registerType('externaltask-event-listener', ExternalTaskEventListener);
Expand Down
20 changes: 11 additions & 9 deletions externaltask-input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ module.exports = function (RED) {
const client = node.engine.engineClient;

if (!client) {
node.error('No engine configured.');
node.error('No engine configured.', {});
return;
}
const etwCallback = async (payload, externalTask) => {
const saveHandleCallback = (data, callback) => {
try {
callback(data);
} catch (error) {
node.error(`Error in callback 'saveHandleCallback': ${error.message}`);
node.error(`Error in callback 'saveHandleCallback': ${error.message}`, {});
}
};

Expand Down Expand Up @@ -138,7 +138,8 @@ module.exports = function (RED) {
case 'finishExternalTask':
case 'processExternalTask':
node.error(
`Worker error ${errorType} for *external task flowNodeInstanceId* '${externalTask.flowNodeInstanceId}' and *processInstanceId* '${externalTask.processInstanceId}': ${error.message}`
`Worker error ${errorType} for *external task flowNodeInstanceId* '${externalTask.flowNodeInstanceId}' and *processInstanceId* '${externalTask.processInstanceId}': ${error.message}`,
{}
);

if (externalTask) {
Expand All @@ -149,11 +150,10 @@ module.exports = function (RED) {
break;
case 'fetchAndLock':
node.status({});
node.error(`Worker error ${errorType}: ${error.message}`);
node.error(`Worker error ${errorType}: ${error.message}`, {});
break;
default:
// reduce noise error logs
// node.error(`Worker error ${errorType}: ${error.message}`);
break;
}
});
Expand All @@ -162,24 +162,26 @@ module.exports = function (RED) {
externalTaskWorker.start();
showStatus(node, Object.keys(started_external_tasks).length);
} catch (error) {
node.error(`Worker start 'externalTaskWorker.start' failed: ${error.message}`);
node.error(`Worker start 'externalTaskWorker.start' failed: ${error.message}`, {});
}

node.on('close', () => {
try {
externalTaskWorker.stop();
} catch {
node.error('Client close failed');
node.error('Client close failed', {});
}
});
})
.catch((error) => {
node.error(`Error in subscribeToExternalTaskTopic: ${error.message}`);
node.error(`Error in subscribeToExternalTaskTopic: ${error.message}`, {});
});
};

if (node.engine) {
register();
register().catch((error) => {
node.error(error, {});
});
}
}

Expand Down
4 changes: 2 additions & 2 deletions message-event-trigger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = function (RED) {
const client = node.engine.engineClient;

if (!client) {
node.error('No engine configured.');
node.error('No engine configured.', msg);
return;
}

Expand All @@ -28,7 +28,7 @@ module.exports = function (RED) {
});
})
.catch((error) => {
node.error(error);
node.error(error, msg);
});
});
}
Expand Down
Loading
Loading