Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invalid JSON on MessageEventTrigger #76

Closed

Conversation

luisthieme
Copy link
Contributor

No description provided.

@luisthieme luisthieme requested a review from maxzxl January 15, 2025 09:22
@luisthieme luisthieme self-assigned this Jan 15, 2025
Copy link
Member

@moellenbeck moellenbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich würde es so nicht umsetzen

@ElRaptorus @roblen45

@@ -15,7 +15,7 @@ module.exports = function (RED) {
node.engine.engineClient.events
.triggerMessageEvent(config.messagename, {
processInstanceId: msg.processinstanceid,
payload: msg.payload,
payload: { payload: msg.payload },
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mit diesem Ergebnis habe ich aber immer "payload" als Schlüssel dabei. Schau mal das Servicedesk-Ticket an.

https://5minds.atlassian.net/browse/PSD-35

Da ist ein Beispiel drin. Schau mal und melde Dich dann noch einmal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich hab leider keinen Zugriff auf den LInk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisthieme wir (@roblen45 ) und ich haben den Fix gemacht. Es node.error kann mit dem catch-Error-Node angefangen werden. So dass es bei dem message-send-Node bereits vorhanden war. Wir haben die notwendigen Änderungen alle übernommen und in das Paket 1.6.5 eingebaut. (Dev: 1.6.5-develop-054f70-m5yacm5t)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants