Fixes for BaseIcon and BaseIconStats #439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllyJaxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 28.00 Epic has begun making shotguns with a headshot cap set that don't actually reach that damage, causing FModel to incorrectly read the headshot damage as higher than it is. This code (whilst probably not the best) fixes that.
Additional note, the
mdpc > 0fmay seem redundant, but it's there to make sure that old versions of the game prior to headshot cap being added still read headshot damage correctly.Added a check for if the season number is 10 and 27, this fixes Season X being read as "Season 10" and Chapter 4: Season OG being read as "Chapter 4: Season 5".