Skip to content

Feature/code analysis #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feature/code analysis #2

wants to merge 6 commits into from

Conversation

gjkaal
Copy link

@gjkaal gjkaal commented Jan 17, 2024

Directory en build props om versiebeheer voor verschillende projecten eenvoudiger te maken, code analyse exstensies toegevoegd en de code analyse issues gefixt

Copy link
Member

@nikneem nikneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik heb een paar vragen toegevoegd

@nikneem nikneem added the enhancement New feature or request label Jan 19, 2024
# Conflicts:
#	src/Wam.Core/Configuration/ServiceCollectionExtensions.cs
@gjkaal
Copy link
Author

gjkaal commented Jan 22, 2024

@nikneem , wijzigingen na review.
Wat is nu het criterium om te mergen naar main? Doet de revewer dat, doe jij dat of doe ik dat als alle issues gefixt zijn. Dat is me niet geheel duidelijk.

Andere vraag: wil je de wijzigingen (build.props, code analyse) ook in de andere C# projecten hebben?

# Conflicts:
#	src/Wam.Core/Configuration/ServicesConfiguration.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants