Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: url 도메인 설정 추가 #164

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

coke98
Copy link

@coke98 coke98 commented Oct 10, 2023

🤨 Motivation

🔑 Key Changes

  • 기존 서버 아이피로 되어있던 API 요청 URL을 도메인으로 변경
  • 채팅과 멤버 서버를 분리하여 도메인 적용

🙏 To Reviewers

  • 혹시 Apis.dart외에 다른 곳에도 도메인을 적용해야할 곳이 있을까요?

@urlotus
Copy link
Contributor

urlotus commented Oct 11, 2023

웹소켓 url은 채팅 서버 도메인으로 적용해야할까요?
chatting_page.dart 에 웹소켓 연결 url이 도메인 3.34.2.246 으로 되어 있습니다!

@coke98
Copy link
Author

coke98 commented Oct 12, 2023

chatting_page.dart내 웹소켓 연결 url도 채팅 도메인으로 변경했습니다! 감사합니당

@urlotus urlotus merged commit 59d0321 into develop Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants