전체게시판 오류 수정 #116
Merged
전체게시판 오류 수정 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urlotus
reviewed
Aug 30, 2023
| ], | ||
| ), | ||
| actions: [ | ||
| IconButton(onPressed: (){}, icon: Icon(Icons.notifications_none, size: 30.h,)), |
There was a problem hiding this comment.
아이콘 같은 거 사이즈를 .h로 해서 height 기준으로 하면 z플립 같은 height가 긴 화면에서는 아이콘이 엄청 커지는 경우가 있더라구요..!! 확인해봐야겠지만 혹시나해서 말씀드립니답
There was a problem hiding this comment.
아 나중에 긴 화면에뮬레이터로 확인해봐야겠네요 감사합니다
urlotus
reviewed
Aug 30, 2023
| final articles = await APIs.TotalArticles(); | ||
| setState(() { | ||
| }); | ||
| } catch (e) { |
There was a problem hiding this comment.
나중에 AT-C-002 같은 액세스 토큰 만료 에러 처리하는 부분도 추가되면 될 것 같습니다!!
urlotus
reviewed
Aug 30, 2023
| @@ -27,6 +27,6 @@ subprojects { | |||
| project.evaluationDependsOn(':app') | |||
| } | |||
|
|
|||
| task clean(type: Delete) { | |||
| tasks.register("clean", Delete) { | |||
There was a problem hiding this comment.
새 환경에서 받아오면서 오류가 생겨 오류 해결 중에 수정한 부분인거같습니다 아마 신경안쓰셔도 될거예요..!!
urlotus
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤨 Motivation
🔑 Key Changes
🙏 To Reviewers