-
Notifications
You must be signed in to change notification settings - Fork 0
COMMON: 7기 통합 온보딩 제출(v2) #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gykoh42
wants to merge
121
commits into
main
Choose a base branch
from
greeting_card
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
49d8a62
[FE] FEAT: 페이지 생성
4a1fce9
[FE] FEAT: prettier 설정
7b4798b
[FE] FEAT: provider
017af97
[FE] FEAT: reset-css용 파일 추가
jihyunk03 bb1e39b
[FE] FEAT: 라우팅 구현
wet6123 a54ccb8
[FE] FEAT: 커스텀 axios 인스턴스와 API 서비스 구현
wet6123 6b8192d
[FE] REMOVE: LoginTemplete.tsx 삭제
gykoh42 f570b24
[FE] FIX: LoginPage 를 기본 경로로 지정
gykoh42 2e187c3
[FE] FIX: RouterProvier 의 route를 router로 변경
gykoh42 cc94a67
[FE] FEAT: LoginInputField 구현
gykoh42 b96c823
[FE] FEAT: LoginPage 구현
gykoh42 82f1d8d
[FE] FEAT: RegisterPage 구현
gykoh42 5159d3d
[FE] CHORE: SendInputField 파일에 임의로 {} export
gykoh42 d7d13af
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
gykoh42 9c343a6
[FE] FEAT: LoginInputField 컴포넌트의 width를 350px로 조정
gykoh42 4757c19
[FE] REMOVE: LoginInputField.tsx 삭제
gykoh42 bf25e07
[FE] FIX: LoginInputField 컴포넌트를 UserInputField 로 변경
gykoh42 98de162
[FE] FEAT: Link 컴포넌트 클릭시 Register 페이지로 이동하도록 구현
gykoh42 68f5949
[FE] FEAT: input 필트와 버튼 css 속성 조정
gykoh42 7f9fdc4
[FE] FEAT: sendPage 구조
1243c1b
[FE] FEAT: LoginPage, RegisterPage 에 폰트 속성 적용
gykoh42 a194aac
[FE] FEAT: custom.d.ts 파일 생성
gykoh42 c0370b5
[FE] FEAT: newYear.svg 파일 추가
gykoh42 6c9322c
[FE] FEAT: newYear.svg 파일 추가
gykoh42 e129b27
[FE] FEAT: 로그인 페이지에 NewYearImg 추가
gykoh42 6e47385
[FE] CHORE: 불필요한 import 제거
wet6123 3eeef4e
[FE] FEAT: 덕담 리스트 불러오기 구현
wet6123 1c5492e
[FE] FIX: reset-css 수정 및 전역 적용
jihyunk03 de24540
[FE] FEAT: send page의 input, textarea 컴포넌트 적용
jihyunk03 ea100c3
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 aa570b6
[FE] FEAT: constant 파일 추가
wet6123 48cec0a
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 87d9014
FIX : RDS, S3 연결 되도록 환경 설정.
lamodadite 299c21d
TEST : H2 test를 위해 테이블 이름 User -> Users로 변경 (User가 h2의 예약어라서 테이블 생성이 안됨)
lamodadite 0a7118b
TEST : H2 test를 위해 설정 변경
lamodadite c04bd57
FEAT : 로그인 기능 구현
lamodadite 4225a8c
[FE] FEAT: UserInputField 의 placeholder 정렬 center 에서 left 로 수정
gykoh42 e4956ed
FEAT : 로그인 기능 구현
lamodadite 7159ecc
FEAT : auth check 기능 구현
lamodadite 1bb1996
FEAT : 유저 목록 검색 기능 구현
lamodadite 042ea38
FEAT : 그룹 목록 검색 기능 구현
lamodadite bed73c5
FIX : Cookie value를 name에서 userName으로 변경
lamodadite 212da6b
FEAT : 메세지 보내기 기능 구현
lamodadite c46ab82
FIX : verifyNameLengthUnder10 -> verifyNameLength로 변경, 상수값 변수로 뺌
lamodadite 530ecc6
FIX : @everyone으로 들어왔을때 reciever에 @everyone이 그대로 들어가도록 변경
lamodadite 8c066f2
FEAT : 메세지 조회 기능 구현
lamodadite 0ad4048
FEAT : 메세지 수정 기능 구현
lamodadite d5ca475
FIX : 쿠키 체크 부분 변경
lamodadite fdba3bc
FIX : 쿠키 밸류 name -> userName
lamodadite 8c4ae99
REFACTOR : 같은 기능을 하는 코드 간결하게 변경
lamodadite dd828b0
FIX : Exception에 errorCode 추가 및 구조 변경
lamodadite f9d5f60
DOCS : 기능마다 주석 달기
lamodadite 115ac9a
FEAT : 메세지 보내기 시 받는 사람과 보내는 사람이 같을때 예외 처리
lamodadite 895f25d
REFACTOR : 코드 정리
lamodadite 5212817
[FE] FEAT: 동적검색기능구현
b93cf1f
[FE] FIX: 버튼 사이즈 수정
b05b5d0
[FE] FEAT: 로그인 유효성 검사 로직 추가
gykoh42 e4798b5
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
gykoh42 2508a2e
Merge branch 'be/onboarding_v2' into fe/onboarding_v2
jihyunk03 bac45de
[FE] FEAT: 회원가입 유효성 검사 로직 추가
gykoh42 402b2ed
Merge remote-tracking branch 'origin/fe/onboarding_v2' into be/onboar…
lamodadite fcf5b2e
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 bead852
Merge remote-tracking branch 'origin/fe/onboarding_v2' into be/onboar…
lamodadite cd3b02b
[FE] FEAT: 비밀번호 입력 필드 password 속성 추가
gykoh42 67cbb2f
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 755effd
[FE] FIX: 검색 api 요청
3586ec7
[FE] FIX: Chrome 자동완성으로 인한 Warning 해결
gykoh42 94782d1
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
gykoh42 e44e136
REFACTOR : docker-compose 파일에 .env 인식할 수 있도록 추가
lamodadite 3593b96
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 54a6c2b
Merge branch 'be/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 81647d0
[FE] FIX: BE 포트번호 변경
jihyunk03 a5855c2
[FE] FIX: 비밀번호 필드 type 을 password 로 변경
gykoh42 2e1dcc3
FIX : 메세지 조회할때 페이지 시작 1 -> 0 으로 변경, 응답에 currentPage 추가, application.y…
lamodadite 496b8b7
[FE] FIX: 검색 api 요청
27f1ddf
Merge branch 'be/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 86303f2
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 ba2359c
FIX : dockerfile jdk 버전 17로 변경
lamodadite 18d3dc7
[FE] FIX: send message header를 multipart로 수정
wet6123 5e9eee0
[FE] FEAT: 로그인 성공시 덕담 리스트 페이지로로 navigate 하는 로직 추가
gykoh42 507aab2
[FE] FIX: 검색 api 요청 수정
429ebff
[FE] FIX: 보내기 api 수정
6c91ee6
[FE] FEAT: 에러 alert 추가
gykoh42 d9b174b
[FE] FIX: 보내기 api 수정
2c83087
[FE] FEAT: accessType에 따라 routing 설정 변경
jihyunk03 d6db73a
[FE] FEAT: public route 추가 및 설정
jihyunk03 c9a19c4
[FE] FIX: list 페이지 리다이렉션 변경
jihyunk03 5963e0b
[FE] FEAT: 로그인/회원가입 문구 수정 및 pattern 프로퍼티 추가
gykoh42 9aa7163
[FE] FIX: 로그아웃 기능추가
e449780
[FE] FEAT: list 인터페이스 구현
wet6123 0a2524c
[FE] FEAT: 카테고리 버튼 구현
wet6123 b45c0cc
[FE] FEAT: 네비게이션 구현
wet6123 b96a7e0
[FE] FEAT: 덕담 박스 구현
wet6123 85e6362
[FE] FEAT: 덕담 리스트 구현
wet6123 d524537
[FE] FEAT: 덕담 리스트 페이지 구현
wet6123 22560c0
[FE] FIX: 정규표현식 수정
gykoh42 7dc7107
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
gykoh42 3f860ab
[FE] FIX: conflict 해결
jihyunk03 410d6a0
[FE] FEAT: 글자수 제한 및 세는 부분 추가
jihyunk03 922eddf
[FE] FEAT: 이미지 모달 구현
wet6123 b0dfc67
[FE] FEAT: list page 스타일
wet6123 07a1730
[FE] FEAT: 리다이렉트 추가
jihyunk03 68ec855
Merge branch 'fe/onboarding_v2' of github.com:42cabi/on-boarding into…
jihyunk03 4c57be1
FIX : 쿠키 확인 로직 추가, 그룹에게 메시지 보낼때 여러개 가는 현상 수정
lamodadite fa1188f
REFACTOR : verify하는 메서드들 전부 아래로 정리
lamodadite 9201b39
[FE] FIX: 색상 형태 통일 및 조정
jihyunk03 cde2dcd
[FE] FIX: route useEffect 버그 픽스
wet6123 485f526
[FE] FIX: messageId 프로퍼티 변경에 따른 수정
wet6123 d0fafd7
[FE] FEAT: 더보기 버튼 스타일링
wet6123 b364674
[FE] FEAT: 메시지 수정 기능 추가
wet6123 96069f5
[FE] FIX: 취소 함수 분리
wet6123 8586217
[FE] FIX: everyone 전송 쿼리 수정
b8dcb43
[FE] FIX: searchResult -> searchList 로 수정
1c273ce
[FE] FEAT: 덕담 리스트 개선
wet6123 504f13e
[FE] FEAT: 덕담 리스트 초기 로딩을 로더로 개선
wet6123 9ab771d
[FE] FIX: 카테고리 버튼 타입 개선
wet6123 6b52245
[FE] FEAT: 덕담 리스트 로드 함수 개선
wet6123 ce01021
[FE] REMOVE: Logout 관련 로직 삭제
gykoh42 001c85d
[FE] FEAT: input 필드 유효성 검사 로직 추가
gykoh42 baed39b
Merge branch 'fe/onboarding_v2' into greeting_card
gykoh42 e856714
[FE] FIX: searchResult 컴포넌트로 분리, 함수 이름 변경
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,4 +36,5 @@ out/ | |
|
|
||
| ### VS Code ### | ||
| .vscode/ | ||
| .env | ||
| .env | ||
| v2/backend/greetingCard/src/main/resources/application.properties | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
v2/backend/greetingCard/src/main/java/com/cabi/greetingCard/dto/GroupSearchDto.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.cabi.greetingCard.dto; | ||
|
|
||
| import java.util.List; | ||
| import lombok.AllArgsConstructor; | ||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @AllArgsConstructor | ||
| public class GroupSearchDto { | ||
|
|
||
| List<String> GroupNames; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
...kend/greetingCard/src/main/java/com/cabi/greetingCard/message/domain/MessageCategory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.cabi.greetingCard.message.domain; | ||
|
|
||
| import lombok.Getter; | ||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @RequiredArgsConstructor | ||
| @Getter | ||
| public enum MessageCategory { | ||
|
|
||
| TO_EVERYONE("@everyone", 0), | ||
| TO_ME("to_me", 1), | ||
| FROM_ME("from_me", 2); | ||
|
|
||
| private final String name; | ||
| private final int number; | ||
| } |
5 changes: 5 additions & 0 deletions
5
...reetingCard/src/main/java/com/cabi/greetingCard/message/repository/MessageRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,15 @@ | ||
| package com.cabi.greetingCard.message.repository; | ||
|
|
||
| import com.cabi.greetingCard.message.domain.Message; | ||
| import org.springframework.data.domain.Page; | ||
| import org.springframework.data.domain.Pageable; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository | ||
| public interface MessageRepository extends JpaRepository<Message, Long> { | ||
|
|
||
| Page<Message> findAllByReceiverName(String receiverName, Pageable pageable); | ||
|
|
||
| Page<Message> findAllBySenderName(String name, Pageable pageable); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
단순한 내용이라 상관없을 것 같지만, 복잡한 DTO라면 어노테이션으로 스웨거 example을 명시해주면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example이 있으면 가독성이 훨씬 좋아지겠네요! 조언해주셔서 감사합니다 :)