Repository navigation
Make WebRTC optional and allow configuring TURN servers - #830
Merged
Merged
Conversation
With this change, WebRTC is no longer enabled by default, and its dependency is not being installed either. That removes the need to install all kinds of A/V stuff if the user does not even use that. Also, this adds support for TURN servers. WebRTC is a peer-to-peer service, so if the bot is running in a Docker container or behind some sort of NAT and the user is not in the same network, a relaying service is required. That's TURN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this change, WebRTC is no longer enabled by default, and its dependency is not being installed either.
That removes the need to install all kinds of A/V stuff if the user does not even use that.
Also, this adds support for TURN servers. WebRTC is a peer-to-peer service, so if the bot is running in a Docker container or behind some sort of NAT and the user is not in the same network, a relaying service is required. That's TURN.
Checklist
--line-length 120argument