[IDLE-000] 알림 동의 로직을 Domain에서 제거 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseFeature의 싱글톤 객체가 담당하도록 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경된 점
BaseFeature의 싱글톤 객체가 담당하도록 구현
Presentation의 관심사라고 볼 수 있는 UserNotifications프레임워크의 기능을, 로직 공유의 목적으로 Domain객체가 가질 필요가 없다고 판단했습니다.
따라서 Presentation레이어의 최하단 모둘(의존성 최 하단)BaseFeature에 해당 역할을 하는 객체를 만들어 알림동의 로직을 보유하도록 구현했습니다.