Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경된점
Amplitude로깅추가
특정 기능이 로깅시스템을 사용하돼 의존성 주입을 위해 각 Feature별 Logger인터페이스를 만들었습니다.
![image](https://private-user-images.githubusercontent.com/106458638/368427943-d77aeb8d-e7fe-4c31-b055-53fc1cf1ecc0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDEwNzQsIm5iZiI6MTczOTI0MDc3NCwicGF0aCI6Ii8xMDY0NTg2MzgvMzY4NDI3OTQzLWQ3N2FlYjhkLWU3ZmUtNGMzMS1iMDU1LTUzZmMxY2YxZWNjMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQwMjI2MTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYjRhNGIwMTFjNGI5ZjEwMDlhMDJmMzYzZGRhODkzMWNjZDA5ZTEwYzYzYWJjYzg0ZWNhOTFhNDAxZWZmY2Y2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.vkzSf4TMVHpuMdoyW2UOKCV-REs9IDnDeHaovtuULN4)
로깅시스템이 복잡하지 않다고 판단하여 하나의 타입(OverallLogger)에서 모든 로깅로직 프로토콜의 구체타입을 구현하도록 했습니다.
DefaultOverallLogger는 실제로 이벤트를 전송하는 객체(publishr)를 프로퍼티로 가집니다.
해당 객체를 의존성 주입을 통해 콘솔 출력용 Debug용 객체와 Amplitude를 사용한 실제 로깅 객체를 주입가능하도록 구현했습니다.
각각의 로커 interface에는 동일한 객체가 주입되는 구조이며, 해당 객체(overallLogger)는 DI컨테이너에 의해 단 하나의 인스턴스만 생성됩니다.
Ampltude에 로깅이 잘 찍히는 것을 확인할 수 있었습니다.
변경된 UI반영