-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDLE-000] 요양보호사 공고지원하기 #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # project/Projects/Data/DataSource/DTO/RecruitmentPost/RecuritmentPostListForWorkerDTO.swift
present한 ViewController를 곧바로 dismiss할경우 올바르게 dismiss되지 못한다, 등장/퇴장 애니메이션이 충돌할 수 있기 때문이다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경된점
요양보호사는 공고에 지원할 수 있다.
기존에 Cell마다 ViewModel을 보유하는 시스템을 개선했습니다.
![image](https://private-user-images.githubusercontent.com/106458638/363938293-71cc9117-5aca-498b-9397-d65e3e8ef85f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDY0ODMsIm5iZiI6MTczOTUwNjE4MywicGF0aCI6Ii8xMDY0NTg2MzgvMzYzOTM4MjkzLTcxY2M5MTE3LTVhY2EtNDk4Yi05Mzk3LWQ2NWUzZThlZjg1Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwNDA5NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMzhmMGQxM2JmMmMxYWQxNGU2OGE2MWJlZDM0MjAwMmE2ODUyZDIzNWQwNmM0ZDQwYWRjNjUzY2E0Y2Q3ZjU2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.cV-QCkTWtcP4l9kVoYf0VQmahzzsKpTmtZTHKj0XgGo)
Cell은 테이블 뷰의 ViewModel에 기능을 사용합니다. 각가의 셀은 postId를 사용하여 호출의 주체를 인식할 수 있도록 변경하였습니다.
테이블 뷰모델이 규모가 커지는 단점이 있지만, Cell마다 존재하는 ViewModel을 1개로 압축함으로써, 매모리를 아낄 수 있습니다.
그리고 Cell에서 발생하는 이벤트를 테이블 뷰에서 직접 수신할 수 있다는 점에서, 상호작용의 깊이가 줄어들게 됩니다.
코드가독성이 올라갔음으로 적절한 트레이드 오프라고 생각합니다.
테이블 뷰모델에 구현한 매서드입니다.
![스크린샷 2024-09-03 오후 7 16 46](https://private-user-images.githubusercontent.com/106458638/363941245-0ee4d14d-cc6c-4495-b506-91704a2efee5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDY0ODMsIm5iZiI6MTczOTUwNjE4MywicGF0aCI6Ii8xMDY0NTg2MzgvMzYzOTQxMjQ1LTBlZTRkMTRkLWNjNmMtNDQ5NS1iNTA2LTkxNzA0YTJlZmVlNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwNDA5NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NDg0OGY2MWRhNjcyNTRlOTQ3NmU4NGMyMmY5N2RhMDM0YzI4YzZmOGI5N2FjNWQzYWMzMWY5NWM0MmFjMWJiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0G5-bSgNSbK3TLK4ekqR3sUi6yYVzH17dY1siQKq1Ys)
셀전용 ViewModel프로토콜을 테이블 뷰가 추가로 구현하는 방식으로 구현하여, Cell의 재사용성은 떨어지지 않도록 했습니다.
Cell의 바인드 함수
![스크린샷 2024-09-03 오후 7 17 25](https://private-user-images.githubusercontent.com/106458638/363940687-1b0984e4-776d-4b3e-8789-5c526da198fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MDY0ODMsIm5iZiI6MTczOTUwNjE4MywicGF0aCI6Ii8xMDY0NTg2MzgvMzYzOTQwNjg3LTFiMDk4NGU0LTc3NmQtNGIzZS04Nzg5LTVjNTI2ZGExOThmZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwNDA5NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jYWUzNDQ3NDkxM2E2ZmI0Y2NlNjkxNGFiNjJkOGYxMGFkNzRlNTQ5ODM0ZDg3YTkwYjc4YTY2Zjc2Nzk4MGQ5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.gzXzzFiABLN8Yfh_3C1V8-Dju1y75OcunyLTg3orngE)