Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes from inspector 2 #1043

Merged
merged 6 commits into from
Feb 1, 2025
Merged

Backport fixes from inspector 2 #1043

merged 6 commits into from
Feb 1, 2025

Conversation

@vincentfretin vincentfretin requested a review from kfarr January 27, 2025 14:57
@vincentfretin vincentfretin self-assigned this Jan 27, 2025
@kfarr
Copy link
Collaborator

kfarr commented Jan 27, 2025

wow TIL about if in the schema:
aframevr/aframe@745591a

@vincentfretin
Copy link
Collaborator Author

Yes, you have that in material, geometry and light. I don't think this is even documented. From my understanding this is not even used, it doesn't trigger an update of the schema, like adding shader attributes to the material schema. But that's a useful information to modify the properties shown in the UI.

@kfarr kfarr merged commit df66628 into main Feb 1, 2025
1 check passed
@kfarr kfarr deleted the backport-from-inspector2 branch February 1, 2025 21:04
@vincentfretin
Copy link
Collaborator Author

Nice, I'm glad you got an usage for the if condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants