Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images #120

Merged
merged 12 commits into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Integration tests
name: Test

on:
pull_request:
Expand Down Expand Up @@ -30,5 +30,12 @@ jobs:
make download
make docker_volume_create
make docker_up
- name: Run unit tests
run: make test
- name: Recreate volumes
run: |
make docker_down
make docker_volume_recreate
make docker_up_nobuild
- name: Run integration tests
run: make test_integration
34 changes: 0 additions & 34 deletions .github/workflows/unit-tests.yaml

This file was deleted.

8 changes: 4 additions & 4 deletions docker/compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ services:
container_name: bag3d-data-postgresql
healthcheck:
test: ["CMD-SHELL", "pg_isready -d ${BAG3D_PG_DATABASE}"]
interval: 7s
retries: 7
start_period: 60s
timeout: 30s
interval: 3s
retries: 10
start_period: 30s
timeout: 10s
shm_size: '1gb'
ports:
- "${BAG3D_PG_PORT_ON_HOST}:5432"
Expand Down
2 changes: 1 addition & 1 deletion docker/pipeline/bag3d-core.dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM 3dgi/3dbag-pipeline-tools:2024.12.05 AS develop
FROM 3dgi/3dbag-pipeline-tools:2024.12.05-1 AS develop
ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline

LABEL org.opencontainers.image.authors="Balázs Dukai <[email protected]>"
LABEL org.opencontainers.image.vendor="3DBAG"
LABEL org.opencontainers.image.title="3dbag-pipeline-core"
LABEL org.opencontainers.image.description="The core workflow package of the 3dbag-pipeline. Image for building the pipeline packages."
LABEL org.opencontainers.image.version=$VERSION

Check warning on line 8 in docker/pipeline/bag3d-core.dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$VERSION' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
LABEL org.opencontainers.image.licenses="(MIT OR Apache-2.0)"

WORKDIR $BAG3D_PIPELINE_LOCATION
Expand Down
2 changes: 1 addition & 1 deletion docker/pipeline/bag3d-floors-estimation.dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM 3dgi/3dbag-pipeline-tools:2024.12.05 AS develop
FROM 3dgi/3dbag-pipeline-tools:2024.12.05-1 AS develop
ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline

LABEL org.opencontainers.image.authors="Balázs Dukai <[email protected]>"
LABEL org.opencontainers.image.vendor="3DBAG"
LABEL org.opencontainers.image.title="3dbag-pipeline-floors-estimation"
LABEL org.opencontainers.image.description="The floors_estimation workflow package of the 3dbag-pipeline. Image for building the pipeline packages."
LABEL org.opencontainers.image.version=$VERSION

Check warning on line 8 in docker/pipeline/bag3d-floors-estimation.dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$VERSION' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
LABEL org.opencontainers.image.licenses="(MIT OR Apache-2.0)"

WORKDIR $BAG3D_PIPELINE_LOCATION
Expand Down
2 changes: 1 addition & 1 deletion docker/pipeline/bag3d-party-walls.dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM 3dgi/3dbag-pipeline-tools:2024.12.05 AS develop
FROM 3dgi/3dbag-pipeline-tools:2024.12.05-1 AS develop
ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline

LABEL org.opencontainers.image.authors="Balázs Dukai <[email protected]>"
LABEL org.opencontainers.image.vendor="3DBAG"
LABEL org.opencontainers.image.title="3dbag-pipeline-party-walls"
LABEL org.opencontainers.image.description="The party_walls workflow package of the 3dbag-pipeline. Image for building the pipeline packages."
LABEL org.opencontainers.image.version=$VERSION

Check warning on line 8 in docker/pipeline/bag3d-party-walls.dockerfile

View workflow job for this annotation

GitHub Actions / build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$VERSION' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
LABEL org.opencontainers.image.licenses="(MIT OR Apache-2.0)"

RUN rm -rf $VIRTUAL_ENV
Expand Down
3 changes: 3 additions & 0 deletions makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ docker_up_postgres:
docker_up:
BAG3D_DOCKER_IMAGE_TAG=$(BAG3D_DOCKER_IMAGE_TAG) docker compose -p $(COMPOSE_PROJECT_NAME) -f docker/compose.yaml up -d

docker_up_nobuild:
BAG3D_DOCKER_IMAGE_TAG=$(BAG3D_DOCKER_IMAGE_TAG) docker compose -p $(COMPOSE_PROJECT_NAME) -f docker/compose.yaml up -d --no-build

docker_watch:
BAG3D_DOCKER_IMAGE_TAG=$(BAG3D_DOCKER_IMAGE_TAG) docker compose -p $(COMPOSE_PROJECT_NAME) -f docker/compose.yaml watch

Expand Down
2 changes: 1 addition & 1 deletion packages/common/src/bag3d/common/resources/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
data_dir=str(Path(os.getenv("BAG3D_FILESTORE")) / "integration_core")
)

# Configure for gilfoyle
# Configure for gilfoyle
file_store_gilfoyle = FileStoreResource(data_dir="/data")
file_store_gilfoyle_fastssd = FileStoreResource(data_dir="/fastssd/data")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def create_roofer_config(
source = {ahn5_files}

[output-attributes]
status = "b3_status"
success = "b3_status"
extrusion_mode = "b3_extrusiemodus"
reconstruction_time = "b3_t_run"
val3dity_lod12 = "b3_val3dity_lod12"
val3dity_lod13 = "b3_val3dity_lod13"
Expand Down
Loading