-
Notifications
You must be signed in to change notification settings - Fork 0
[feat/#267] 퀘스트 작성 UI 변경 및 추가, 스크롤 추가 #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,746
−1,446
Merged
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
67a60e8
#267 [move]: quest 작성, 완료 패키지 분리
znayeonzn 3818121
#267 [move]: quest 작성, 완료 패키지 분리
znayeonzn 6f81ee3
#267 [feat]: 퀘스트 작성 UI 수정 및 텍스트 스크롤 추가
znayeonzn 70e256e
#267 [feat]: 퀘스트 완료 모달 띄우기
znayeonzn 6a705c1
#267 [chore]: ktlint format
znayeonzn d6c40a3
#267 [merge] : develop 브랜치 반영
znayeonzn 216434a
#267 [move] : behavior quest package 분리
znayeonzn cf71910
#267 [fix] : 텍스트 필드가 포커스된 상태일 때만 스크롤 동작하도록 수정
znayeonzn 3713b4e
#267 [chore] : 함수 네이밍 수정
znayeonzn 6359e7a
#267 [feat] : 행동형 퀘스트 작성 UI 및 스크롤 기능 추가
znayeonzn 18244dd
#267 [merge]: conflict 해결
znayeonzn 300a3ca
#267 [fix]: imepadding, scroll 문제 해결
znayeonzn 2952ad7
#267 [feat]: 공통 퀘스트 UI
znayeonzn df06ebf
#267 [feat]: 공통 퀘스트 네비 연결
znayeonzn 3d354b8
#267 [merge] : develop 브랜치 반영
znayeonzn 33b4296
#267 [feat] : response 필드 추가
znayeonzn 7f14a5c
#267 [feat] : 행동형 퀘스트 완료 화면 UI 구현
znayeonzn 84bfc02
#267 [mod] : 코드 리뷰 반영
znayeonzn 0285cf2
#267 [chore] : 코드리뷰 반영
sohee6989 20cdad8
#267 [chore] : ktlinnt 체크
sohee6989 23d91e0
#267 [feat] : 다시보기 화면 - ai 답장 버튼 구현
sohee6989 687f842
#267 [chore] : 행동형 완료 화면 버튼 간격 변경
sohee6989 be2b7cb
#267 [chore] : 안쓰는 주석 삭제
sohee6989 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 167
🏁 Script executed:
# 파일 내용 확인 (사이즈 먼저) wc -l app/src/main/java/com/byeboo/app/data/dto/response/quest/QuestRecordedDetailResponseDto.ktRepository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 168
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 1070
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 101
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 101
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 101
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 427
🏁 Script executed:
# 다른 DTO 파일들의 Boolean 필드 패턴 확인 cat app/src/main/java/com/byeboo/app/data/dto/response/quest/QuestCountResponseDto.ktRepository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 439
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 215
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 57
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 535
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 59
🏁 Script executed:
# QuestRecordedDetailService 구현 확인 cat app/src/main/java/com/byeboo/app/data/service/quest/QuestRecordedDetailService.ktRepository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 514
🏁 Script executed:
# QuestRecordedDetailDataSourceImpl 구현 확인 cat app/src/main/java/com/byeboo/app/data/datasourceimpl/remote/quest/QuestRecordedDetailDataSourceImpl.ktRepository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 811
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 57
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 250
🏁 Script executed:
# 다른 non-null Boolean 필드들의 정의 확인 cat app/src/main/java/com/byeboo/app/data/dto/response/auth/KakaoLoginResponseDto.ktRepository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 652
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 57
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 1896
🏁 Script executed:
Repository: 36-APPJAM-HEARTZ/ByeBoo-ANDROID
Length of output: 313
필수 Boolean 필드 추가로 역직렬화 실패 가능성이 있습니다.
Line 26~27의 aiAnswerExists는 기본값 없는 non-null 필드로, 서버 응답에서 이 필드가 누락되면
MissingFieldException이 발생할 수 있습니다. 특히 서버와 앱 배포 타이밍이 어긋나는 상황에서 앱 크래시 위험이 있습니다.다만, 현재 코드베이스에서 isRegistered(KakaoLoginResponseDto), alarmEnabled(NotificationResponseDto) 등 다른 non-null Boolean 필드들도 동일한 구조로 정의되어 있으므로, 이 이슈는 aiAnswerExists만의 문제가 아니라 전체 DTO 설계 패턴의 일관성 문제입니다.
아래와 같이 기본값을 추가하거나, 서버에서 이 필드가 항상 포함됨을 보장하도록 API 계약을 명확히 해야 합니다:
방어적 수정안
`@SerialName`("aiAnswerExists") - val aiAnswerExists: Boolean + val aiAnswerExists: Boolean = false📝 Committable suggestion
🤖 Prompt for AI Agents