Open
Conversation
Author
|
Hi @2fd, would you mind taking a quick look at this PR so that installing |
2fd
requested changes
Jan 10, 2023
… Because antd Icon component uses document
jljouannic
force-pushed
the
upgrade-everything
branch
from
c038066 to
c855afb
Compare
Author
|
Hi @2fd! Did you find some time to check the fix I pushed following the change you requested? |
Author
|
Hi @2fd, it's been two month since you requested me to make some changes and me complying to this request. Would you mind taking a look before, hopefully, merge this PR and make a new release of this package? 🙏 🥺 |
jljouannic
force-pushed
the
upgrade-everything
branch
from
ae925ac to
1d62954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What else to say? The PR title is explicit enough I think 😄