Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token mint name/symbol, decimals and delegatedAmount USD value #4

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johnrees
Copy link
Contributor

@johnrees johnrees commented Nov 1, 2021

This is a bit of a WIP and the code probably isn't idiomatic Vue but hopefully it is close to what you need.

I'd also like to add a linter like prettier in a separate PR if that's ok, so that spacing etc is consistent.

Before

Screenshot 2021-11-01 at 6 59 42 PM

After

Screenshot 2021-11-01 at 6 58 42 PM

TODO

I need to do some more refactoring and testing before I can say I'm happy with it.

It builds on #3 as there was going to be a lot of commit noise without it.

Checklist incoming...

@johnrees johnrees marked this pull request as draft November 1, 2021 19:34
@2501babe
Copy link
Owner

2501babe commented Nov 3, 2021

ooh this looks nice. is there a reason for avoiding @solana/spl-token-registry? i was gonna just use that but didnt look at its interface yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants