Skip to content

Add maker parameter to hasTargetForHook method #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
belactriple9 wants to merge 2 commits into from
Closed

Add maker parameter to hasTargetForHook method #24

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e29ac1c
Add maker parameter to hasTargetForHook method
belactriple9 Nov 25, 2025
4da096f
Merge branch 'master' into patch-1
vbrvk Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion typescript/swap-vm/src/swap-vm/maker-traits.ts
View file
Open in desktop
Copy link

@aliashrfeanzade aliashrfeanzade Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2ef3d848-2d5c-49c4-8dad-ad2c84655ade

Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ export class MakerTraits {
const { data, offsets } = MakerTraits.HOOKS.reduce(
(acc, hookName, i) => {
const hook = this[hookName]
const hasTarget = this.hasTargetForHook(hookName)
const hasTarget = this.hasTargetForHook(hookName, maker)
const encoded = hook && hasTarget ? hook.encode() : hook?.data || HexString.EMPTY

acc.sum += BigInt(encoded.bytesCount())
Expand Down
Loading