Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[codex] Hide sys log follower unit from argv #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codex] Hide sys log follower unit from argv #2
Changes from all commits
a82ea8dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new validation rejects
sys log <unit> -n +100and the--lines=+100/-n+100variants even though these were previously passed directly to journalctl and are valid; I checkedjournalctl --help, which advertises-n --lines[=[+]INTEGER]. In follow mode this now exits before journalctl runs, so users relying on journalctl's leading-plus line-count semantics lose a supported passthrough option.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the prelude finds no matching entry,
SYS_LOG_AFTER_CURSORis empty and the long-lived follower starts with-n 0;journalctl --helpdescribes-nas the number of entries to show, so this only follows entries that arrive after that second journalctl process is attached. Because the new implementation splits the old singlejournalctl -f -uinvocation into a prelude and a later unscoped follower, any first log line written by the unit in the gap between those two commands is silently missed.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user runs
sys log <unit> --no-tail, journalctl defines--no-tailas showing all lines even in follow mode. The prelude already receives that option and prints the unit's history, but passing the same option through here makes the unscoped follower replay the entire journal again before Python filters it, so the target unit's historical logs are emitted a second time and the command scans all journals unnecessarily. This regresses the documented journalctl passthrough behavior for--no-tail; either consume it in the prelude path or reject it like the other unsupported follow options.Useful? React with 👍 / 👎.