Fix credential item category and add another credential fields #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe part of the problem with the credential category lies in
if f.ID == "credential" && item.Category == "API_CREDENTIAL"
where"credential"
is checked againstf.ID
.I'm not sure if I'm following correctly everything, but I believe the correct
f
field for this comparison should beLabel
notID
. Leaving it like rest of the fields on 350-362 should be sufficient.I followed discussion in the original PR but I don't feel much clearer on it. Just think this shouldn't have been merged without tests.
So, first I added a test for credential category, which successfully failed. Then I tried fixing the issue and discovered the
f.ID
problem. Afterwards I added additional credential fields based on what 1password returns for that category and updated the docs. Thetype
field is shared between both database and credential category.This is also related to #52