Connect chart testing improvements #251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dispatch action workflow system
edif2008
reviewed
Oct 24, 2025
Member
edif2008
left a comment
edif2008
left a comment
There was a problem hiding this comment.
Functional review: ❓
Code review: ✅
Things look really nice. I like how we've extracted the testing so that we can also run it locally.
Other notes
If i accidentally provide wrong configuration details (e.g. wrong Connect token), I needed to clean the setup before running it again. Might be useful to document this.
Comment on lines
+58
to
+62
| @if [ -z "$(OP_SECRET_VALUE)" ]; then \ | ||
| echo "$(RED)Error: OP_SECRET_VALUE environment variable is required$(NC)"; \ | ||
| echo "$(YELLOW)Set OP_SECRET_VALUE to the expected secret value for testing$(NC)"; \ | ||
| exit 1; \ | ||
| fi |
Member
There was a problem hiding this comment.
[nit]
This can be extracted into a target that's not exposed. You can pass variable name, expected string name (e.g. "item ID") and the variable you want to verify to it.
Comment on lines
+19
to
+24
| # Colors for output | ||
| RED := \033[0;31m | ||
| GREEN := \033[0;32m | ||
| YELLOW := \033[0;33m | ||
| BLUE := \033[0;34m | ||
| NC := \033[0m # No Color |
Member
There was a problem hiding this comment.
[maybe non-blocking]
What if the terminal doesn't support colors? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the e2e tests workflow for Connect chart: