Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n bug #2071

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: i18n bug #2071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/locales/lang/en-US/views/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ export default {
source: {
label: 'User Type',
local: 'System User',
wecom: 'WeCom (Enterprise WeChat)',
lark: 'Lark (Feishu)',
wecom: 'WeCom',
lark: 'Lark',
dingtalk: 'DingTalk'
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to be correctly formatted and free of syntax errors related to the localization object within the source section. There are no issues with this specific block of code.

However, there is an opportunity for a minor improvement:
You could combine duplicate values if needed. For example:

export default {
  source: {
    label: 'User Type',
-    local: 'System User',
+    // Assuming "System User" should also map to "WeCom"
    wecom: ['System User', 'WeCom'],
-    lark: 'Lark (Feishu)',
+    lark: 'Lark',
    dingtalk: 'DingTalk'
  }
}

This way, it allows you to map both "Local System User" and "Wecom" to the same value if needed. If these mappings are correct as currently shown, this adjustment would not change the functionality but might make the data more flexible or readable depending on how other parts of your application use the localization information.

Loading